Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kind filter for Goto Symbol command #2330

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Add kind filter for Goto Symbol command #2330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4bc978e
Add kind filter for Goto Symbol command
jwortmann Sep 24, 2023
ed893aa
Keep current key bindings functional and improve item format
jwortmann Sep 25, 2023
a2a8048
Can still use former menu item now
jwortmann Sep 25, 2023
e5bae02
Cleanup
jwortmann Sep 25, 2023
1d1e90a
Fix infinite loop if kind argument is provided but has no symbols
jwortmann Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions plugin/core/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,27 +193,6 @@
sublime.KIND_VARIABLE: "entity.name.constant | constant.other | support.constant | variable.other | variable.parameter | variable.other.member | variable.other.readwrite.member" # noqa: E501
} # type: Dict[SublimeKind, str]

# Recommended colors to use by themes for each symbol kind, based on the kind_container specialization class described
# at https://www.sublimetext.com/docs/themes.html#quick-panel
SUBLIME_KIND_ID_COLOR_SCOPES = {
sublime.KIND_ID_KEYWORD: "region.pinkish",
sublime.KIND_ID_TYPE: "region.purplish",
sublime.KIND_ID_FUNCTION: "region.redish",
sublime.KIND_ID_NAMESPACE: "region.bluish",
sublime.KIND_ID_NAVIGATION: "region.yellowish",
sublime.KIND_ID_MARKUP: "region.orangish",
sublime.KIND_ID_VARIABLE: "region.cyanish",
sublime.KIND_ID_SNIPPET: "region.greenish",
sublime.KIND_ID_COLOR_REDISH: "region.redish",
sublime.KIND_ID_COLOR_ORANGISH: "region.orangish",
sublime.KIND_ID_COLOR_YELLOWISH: "region.yellowish",
sublime.KIND_ID_COLOR_GREENISH: "region.greenish",
sublime.KIND_ID_COLOR_CYANISH: "region.cyanish",
sublime.KIND_ID_COLOR_BLUISH: "region.bluish",
sublime.KIND_ID_COLOR_PURPLISH: "region.purplish",
sublime.KIND_ID_COLOR_PINKISH: "region.pinkish"
} # type: Dict[int, str]

DOCUMENT_HIGHLIGHT_KINDS = {
DocumentHighlightKind.Text: "text",
DocumentHighlightKind.Read: "read",
Expand Down
2 changes: 1 addition & 1 deletion plugin/goto_diagnostic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def next_input(self, args: dict) -> Optional[sublime_plugin.CommandInputHandler]
if diagnostic is None:
self._preview = None
return DiagnosticInputHandler(self.window, self.view, uri)
return sublime_plugin.BackInputHandler() # type: ignore
return sublime_plugin.BackInputHandler()

def confirm(self, value: Optional[DocumentUri]) -> None:
self.uri = value
Expand Down
Loading