Update instructions for OCaml and ReasonML #2386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <sora@morimoto.io>
rwols
reviewed
Jan 3, 2024
| @@ -344,10 +344,9 @@ | |||
| }, | |||
| "ocaml": { | |||
| "command": [ | |||
| "ocaml-language-server", | |||
| "--stdio" | |||
There was a problem hiding this comment.
Reminder: this change would require some notice in the release notes.
We should first see what ends up in their documentation so that we know what should we add here. Maybe they will not want too specific instructions and just general ones on how to start the server in which case we should document the rest here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to document instructions for Sublime on the OCaml-LSP side, but this change basically allows us to use OCaml-LSP as is.