Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format on paste #2397

Merged
merged 22 commits into from
Feb 2, 2024
Merged

Add format on paste #2397

merged 22 commits into from
Feb 2, 2024

Conversation

predragnikolic
Copy link
Member

@predragnikolic predragnikolic commented Jan 22, 2024

I created a new PR for the "format on paste" feat - I didn't want to resolve the merge conflict with #2311

TODO address these two comments:

Including whitespace does help some servers to format a range as expected like LSP-json,

See: #2311 (comment)
plugin/documents.py Outdated Show resolved Hide resolved
@predragnikolic
Copy link
Member Author

All other code review comments left in #2311 were addressed in this PR.

LSP.sublime-settings Outdated Show resolved Hide resolved
plugin/documents.py Outdated Show resolved Hide resolved
plugin/documents.py Outdated Show resolved Hide resolved
plugin/documents.py Outdated Show resolved Hide resolved
plugin/documents.py Outdated Show resolved Hide resolved
sublime-package.json Outdated Show resolved Hide resolved
plugin/documents.py Outdated Show resolved Hide resolved
Copy link

netlify bot commented Jan 27, 2024

Deploy Preview for sublime-lsp ready!

Name Link
🔨 Latest commit d8f60eb
🔍 Latest deploy log https://app.netlify.com/sites/sublime-lsp/deploys/65bcac6c2c9abf0008f256a7
😎 Deploy Preview https://deploy-preview-2397--sublime-lsp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

plugin/documents.py Outdated Show resolved Hide resolved
plugin/documents.py Outdated Show resolved Hide resolved
predragnikolic and others added 3 commits January 29, 2024 21:49
plugin/documents.py Outdated Show resolved Hide resolved
plugin/documents.py Outdated Show resolved Hide resolved
Before, occasionally it was possible to see a brief moment when text gets selected,
Now, we move that from the async thread to the main thread, thus we will not see that flash
@predragnikolic
Copy link
Member Author

There was some minor visual annoyance, where I could sometimes see the selected regions, before they get formatted, I addressed that with 0cfcc71

LSP.sublime-settings Outdated Show resolved Hide resolved
@predragnikolic predragnikolic merged commit af3b9ee into main Feb 2, 2024
7 of 8 checks passed
@predragnikolic predragnikolic deleted the feat/format-on-paste-2 branch February 2, 2024 08:49
@predragnikolic predragnikolic mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants