-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format on paste #2397
Merged
Merged
Add format on paste #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Including whitespace does help some servers to format a range as expected like LSP-json, See: #2311 (comment)
predragnikolic
commented
Jan 22, 2024
predragnikolic
commented
Jan 22, 2024
All other code review comments left in #2311 were addressed in this PR. |
rchl
reviewed
Jan 23, 2024
So it can be defined in Preferences.sublime-settings
rchl
reviewed
Jan 25, 2024
rchl
reviewed
Jan 25, 2024
jwortmann
reviewed
Jan 25, 2024
…ndent and generally make sure to run format_on_paste if the session supports documentRangeFormattingProvider
✅ Deploy Preview for sublime-lsp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rchl
reviewed
Jan 29, 2024
rchl
reviewed
Jan 29, 2024
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
rchl
reviewed
Jan 29, 2024
rchl
approved these changes
Feb 1, 2024
Before, occasionally it was possible to see a brief moment when text gets selected, Now, we move that from the async thread to the main thread, thus we will not see that flash
There was some minor visual annoyance, where I could sometimes see the selected regions, before they get formatted, I addressed that with 0cfcc71 |
jwortmann
reviewed
Feb 1, 2024
rchl
approved these changes
Feb 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new PR for the "format on paste" feat - I didn't want to resolve the merge conflict with #2311
TODO address these two comments: