Extend completion heuristics for metals' 'implement all members' #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwols
force-pushed
the
bugfix/metals-completions
branch
from
a963c06 to
a960f78
Compare
|
I know that we are limited by Sublime API sublimehq/sublime_text#2754 |
unfortunately, yes :( |
|
@rwols thanks for looking at this so quickly! I tested this out locally, and yes, this does the trick. Probably not ideal that we have to have that coded in there, but I'm not sure of what else to do for it, so I'll leave it up to you if you want to add this in or not. |
tomv564
requested changes
Nov 12, 2019
The replacement is already equal to the textEdit property.
tomv564
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ckipp01 I haven't actually tested this with a snapshot build of MetaLS. Could you try this branch?
close #771