Parse and show related information in diagnostics hover content #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to try this out on clangd |
|
All of the "Candidate constructor ..." lines are DiagnosticRelatedInformation. In both rust and clangd's case, these related diagnostics would stand out better if they had a different background color. Like an "informational" or "note" or "warning" color. Because in both cases they are informational. Like in the terminal:
|
tomv564
force-pushed
the
hover-diagnostic-related-information
branch
from
2f32404 to
a6f0aa4
Compare
|
Agree, thankfully there are lots of shades of grey to use:
From your clangd example the absolute file paths would be better left alone instead of made relative - fixed this as well. |
|
50 shades of popup :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #492
It's pretty ugly, though RLS's duplicate content in the diagnostics doesn't help:
Discussion of how VS Code implemented the UI: microsoft/vscode#10271