fix definition lists #117
fix definition lists #117
Conversation
|
I have revised the code here and pushed onto the branch. Looks good from my side now. PTAL. |
|
Looks good to me |
docs/.vitepress/config.ts
Outdated
| @@ -19,10 +21,10 @@ export default defineConfig({ | |||
| title: 'Sublime Text Community Documentation', | |||
| description: 'Community-driven Documentation for Sublime Text', | |||
| head: customHead, | |||
| appearance: 'dark', | |||
There was a problem hiding this comment.
just in case you didn't know, a local npm install & using LSP-typescript in Sublime helps to prevent a wrong config
There was a problem hiding this comment.
Unless something is wrong in my setup. These things did not throw an error. I caught it by going through the config by hand.
There was a problem hiding this comment.
I almost did that today, but ended up not doing it today because I haven't fully committed my LSP configuration of another machine to my dotfiles repo yet and didn't want to reconfigure everything from scratch.
(I hope LSP-vue works with vitepress …)
Also use the custom <Term> tag throughout the entire documentation texts because the `:term:text_with_underscores:` syntax is inferior to simply including the text (with a slot). With these changes, there is also little to no resemblance to the vuepress glossary plugin that was used before, meaning we should not violate any license anymore.
I initially only committed this because I worked on them anyway, but after I had problems getting it to work in unexpected ways and changed all occurrences to use the Term tag directly, we don't need this (and the dependency) anymore.
Using the default (`true`) means that the user's "preferred color scheme" will be followed, which I interpret as whether the system theme is light or dark. This is a sensible default that we don't need to override
|
I noticed I forgot to commit 4 files, so I force-pushed them. And made a few more changes on top. Merging this to deploy it. |
FichteFoll
added
bug
Config was formatted incorrectly. Bumped vitepress at the same time
fixes #86