Update metadata.md #50
Conversation
Edited 《Indentation Options》section.
| ``` | ||
|
|
||
| `disableIndentNextLinePattern` | ||
| : *Regex.* | ||
| If it matches on the current line, | ||
| the next line will not be indented further. | ||
| and `bracketIndentNextLinePattern`'s *Regex* also matches on the current line. |
There was a problem hiding this comment.
Wouldn't bracketIndentNextLinePattern have matched on the previous line?
https://forum.sublimetext.com/t/everything-you-n-ever-wanted-to-know-about-indentation-in-st3/26207?u=kingkeith
| ``` | ||
|
|
||
| `unIndentedLinePattern` | ||
| : *Regex.* | ||
| If it matches on the current line, |
There was a problem hiding this comment.
I personally think the current wording we have is clearer. It doesn't check if the other regex patterns match, its irrelevant.
|
It would be easier to review if you just pushed new commits to the same branch to update the existing PR, rather than create a new branch and PR each time, as this way all the previous comments are still visible in one place. |
There was a problem hiding this comment.
Please push commits to the existing branch instead of opening new pull requests, as @keith-hall mentioned. I have closed the previous two PRs.
I also strongly suggest to reply to review comments on the website and not via email, als that will group them all together and thus doesn't make use of the context separation of individual review comments.
|
|
||
| ```xml | ||
| <key>bracketIndentNextLinePattern</key> | ||
| <string><![CDATA[^\s*[A-z]]]></string> |
There was a problem hiding this comment.
This regex is basically equivalent to \S for all the examples following, so we might as well simplify it to that as to not make it more complex that it needs to be. It will basically match on every non-blank line.
| ```xml | ||
| lineone only match increaseIndentPattern Regex effects made | ||
| after lineone1 | ||
| after lineone2 |
There was a problem hiding this comment.
I will have to test this locally, but I would have expect this line to be indented further.
In general, I feel like the "examples" are a bit hard to understand because there are no steps for reproduction, i.e. the user cannot really use a mental model to apply the same rules as ST does for the indentation settings. Or at least I have a problem with it.
I believe it will be easier to understand if the examples showed the result of a reindent command having run on the entire example text, similar to how indentation tests function.
Edited 《Indentation Options》section.