Create auth-restricted pages #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazyguru
approved these changes
May 17, 2024
Pdzly
reviewed
May 17, 2024
|
|
||
| const validation = await SublinksApi.Instance().Client().validateAuth(); | ||
| if (!validation.success) { | ||
| redirect('/login'); |
There was a problem hiding this comment.
In the future we should add a query parameter to here, where he wanted to go before getting redirected to login.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of restricted pages. Currently to prevent unauthorized users from seeing the post-creation and community-creation pages. When a unauthed user attempts to visit those pages they'll instead be directed to the login page.
To make this work we're using an experimental NextJS option that allows us to run server actions more freely. And this is used to revalidate all routes to make sure NextJS doesn't cache pages too hard and makes it seem like the user is still logged in after logging out, and vice versa.
We also catch up with the JS client and latest
cross-fetch.As an extra bonus this also changes our forms from using the default
onSubmitto using React form actions to which the form data is passed in for us.