Handle namespace recreated in resource syncer #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr981/tpantelis/handle_ns_delete |
- React to all verbs, not just "create" - When a namesapce is deleted, delete all contained resources - Update unit tests Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
If a namespace is deleted and the namespace was previously seen, ie there was at least one resource previously synced in that namespace, then retrieve all the cached resource keys in the namespace and add them to the missingNamespaces set. If the namespace is later recreated, then those resources will be re-queued and re-synced. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
force-pushed
the
handle_ns_delete
branch
from
feb1674
to
b80228f
Compare
vthapar
approved these changes
Aug 29, 2024
aswinsuryan
approved these changes
Aug 30, 2024
|
🤖 Closed branches: [z_pr981/tpantelis/handle_ns_delete] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a namespace is deleted and the namespace was previously seen, ie there was at least one resource previously synced in that namespace, then retrieve all the cached resource keys in the namespace and add them to the
missingNamespacesset. If the namespace is later recreated, then those resources will be re-queued and re-synced.