Fix SRV records not returned for clusterset IP service #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1681/tpantelis/SRV_clusterset_ip |
4 tasks
skitt
requested changes
Nov 25, 2024
coredns/plugin/handler_test.go
Outdated
|
|
||
| t.lh.Resolver.PutServiceImport(si) | ||
|
|
||
| si.Spec.Ports = []mcsv1a1.ServicePort{port1, port2} | ||
| t.lh.Resolver.PutServiceImport(si) |
There was a problem hiding this comment.
Could you add a comment here explaining why PutServiceImport needs to be called twice? I’m concerned that in a few months’ time someone might see this and remove the earlier PutServiceImport call since it appears redundant.
There was a problem hiding this comment.
I removed the two calls from here as the scenario is handled in clusterip_service_test.go.
|
|
||
| si.Spec.Ports = []mcsv1a1.ServicePort{port1, port2} | ||
| t.resolver.PutServiceImport(si) |
With clusterset IP enabled, we extract the ports from the aggregated ServiceImport instead of the EndpointSlices. However the ports are populated in the ServiceImport sometime after creation so PutServiceImport needs to update the cached spec if it already exists. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
force-pushed
the
SRV_clusterset_ip
branch
from
68068c6 to
4357064
Compare
skitt
approved these changes
Nov 25, 2024
vthapar
approved these changes
Nov 25, 2024
|
🤖 Closed branches: [z_pr1681/tpantelis/SRV_clusterset_ip] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With clusterset IP enabled, we extract the ports from the aggregated
ServiceImportinstead of theEndpointSlices. However the ports are populated in theServiceImportsometime after creation soPutServiceImportneeds to update the cached spec if it already exists.