Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OVN-K image, Upstream KIND hacks, Remove Submariner/ovn-kubernetes fork #703

Closed
1 of 3 tasks
Tracked by #96
astoycos opened this issue Jan 11, 2022 · 1 comment · Fixed by #704
Closed
1 of 3 tasks
Tracked by #96

Update OVN-K image, Upstream KIND hacks, Remove Submariner/ovn-kubernetes fork #703

astoycos opened this issue Jan 11, 2022 · 1 comment · Fixed by #704
Assignees
@astoycos
Labels
OVN priority:high size:medium

Comments

@astoycos
Copy link
Contributor

astoycos commented Jan 11, 2022 •
edited
Loading

The Image being used in shipyard for ovn-kubernetes KIND clusters is

local OVN_SRC_IMAGE="quay.io/vthapar/ovn-daemonset-f:latest"

Which is fairly stale and over a year old. We also maintain a fork of the ovn-kubernetes repo to keep some kind script hacks that should be able to be up streamed in ovn-kubernetes.

My goal with this issue is to accomplish three things

  • Upstream some work to setup a continuous build pipeline in upstream OVN-K the images will be updated on every push to master and stored automatically in the github container registy (ghcr.io) That work can be found here Upstream Submariner kind hacks, setup automatic build and storage of ovn-k images  ovn-kubernetes/ovn-kubernetes#2747
  • Upstream the submariner relevant KIND script hacks to OVN-K these include adding the ability to run the script from a container, explicitly supply a kubeconfig path, explicitly name the cluster, provide a custom DNSdomain, and to integrate with a local docker registry
  • Ultimately remove the submariner/ovn-kubernetes fork so we have one less thing to maintain
@astoycos
Copy link
Contributor Author

I am actively working on this :)

astoycos added a commit to astoycos/shipyard that referenced this issue Jan 11, 2022
@astoycos
Update OVN-K image
7f2b83a 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@astoycos astoycos mentioned this issue Jan 11, 2022
Merged
astoycos added a commit to astoycos/shipyard that referenced this issue Jan 12, 2022
@astoycos
Update OVN-K image
542e532 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@astoycos astoycos mentioned this issue Jan 13, 2022
Merged
astoycos added a commit to astoycos/shipyard that referenced this issue Jan 13, 2022
@astoycos
Update OVN-K image
c503a0e 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@nyechiel nyechiel added the OVN label Jan 14, 2022
astoycos added a commit to astoycos/shipyard that referenced this issue Feb 11, 2022
@astoycos
Update OVN-K image
6320a85 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Feb 11, 2022
@astoycos
Update OVN-K image
3ea35db 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Feb 15, 2022
@astoycos
Update OVN-K image
9e126d8 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Feb 15, 2022
@astoycos
Update OVN-K image
07de0e6 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Feb 15, 2022
@astoycos
Update OVN-K image
5d3d3da 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Feb 15, 2022
@astoycos
Update OVN-K image, download kind script
c5d5ffc 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Feb 28, 2022
@astoycos
Update OVN-K image, download kind script
6312169 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Feb 28, 2022
@astoycos
Update OVN-K image, download kind script
e0559d6 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Feb 28, 2022
@astoycos
Update OVN-K image, download kind script
8872e92 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Mar 1, 2022
@astoycos
Update OVN-K image, download kind script
d6f27da 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Mar 2, 2022
@astoycos
Update OVN-K image, download kind script
4f5365c 
Fixes submariner-io#703

this patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind script which we now download on the fly.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Mar 2, 2022
@astoycos
Update OVN-K image, download kind script
70b14b7 
Fixes submariner-io#703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Mar 8, 2022
@astoycos
Update OVN-K image, download kind script
4b288f6 
Fixes submariner-io#703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Mar 10, 2022
@astoycos
Update OVN-K image, download kind script
a4b2f4c 
Fixes submariner-io#703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@astoycos astoycos mentioned this issue Mar 28, 2022
Closed
28 tasks
astoycos added a commit to astoycos/shipyard that referenced this issue Apr 4, 2022
@astoycos
Update OVN-K image, download kind script
3f4bd9e 
Fixes submariner-io#703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Apr 4, 2022
@astoycos
Update OVN-K image, download kind script
70667dd 
Fixes submariner-io#703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Apr 5, 2022
@astoycos
Update OVN-K image, download kind script
8ba2136 
Fixes submariner-io#703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Apr 8, 2022
@astoycos
Update OVN-K image, download kind script
178651d 
Fixes submariner-io#703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos added a commit to astoycos/shipyard that referenced this issue Apr 13, 2022
@astoycos
Update OVN-K image, download kind script
72301ef 
Fixes submariner-io#703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
skitt pushed a commit that referenced this issue Apr 13, 2022
@astoycos @skitt
Update OVN-K image, download kind script
2ae817b 
Fixes #703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
anfredette pushed a commit that referenced this issue Apr 22, 2022
@astoycos @anfredette
Update OVN-K image, download kind script
ed73774 
Fixes #703

This patch ensures that the upstreamed submariner kind hacks
for ovn-kubernetes are properly used, and ensures we pull
the ovn-k image from the correct location

it also removes the ovn-kubernetes submodule since all we really
need is the OVN-K kind scripts and templates which we now download
on the fly from ovn-kubernetes master.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astoycos astoycos

Labels
OVN priority:high size:medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ovn k kind updates astoycos/shipyard
3 participants
@nyechiel @astoycos @maayanf24