Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapped error is always nil #224

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Wrapped error is always nil #224

merged 2 commits into from
Aug 19, 2022

Conversation

tpantelis
Copy link
Contributor

This was detected by a code scanning tool.

@tpantelis
Wrapped error is always nil
96e96f9 
This was detected by a code scanning tool.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@tpantelis tpantelis requested a review from dfarrell07 August 18, 2022 15:50
@tpantelis tpantelis self-assigned this Aug 18, 2022
@tpantelis tpantelis requested a review from Jaanki as a code owner August 18, 2022 15:50
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr224/tpantelis/wrapped_err_nil
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@dfarrell07 dfarrell07 mentioned this pull request Aug 18, 2022
Closed
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Aug 19, 2022
@tpantelis tpantelis enabled auto-merge (rebase) August 19, 2022 15:10
@tpantelis tpantelis merged commit 9d9cea1 into submariner-io:devel Aug 19, 2022
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr224/tpantelis/wrapped_err_nil]

@tpantelis tpantelis deleted the wrapped_err_nil branch September 2, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@Jaanki Jaanki Awaiting requested review from Jaanki Jaanki is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees

@tpantelis tpantelis

Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tpantelis @submariner-bot @dfarrell07 @skitt