Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to depguard v2 configuration #791

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Conversation

skitt
Copy link
Member

@skitt skitt commented Jun 14, 2023

Depends on #790
Depends on submariner-io/shipyard#1268

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr791/skitt/depguard-v2
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@github-actions
Copy link

This PR/issue depends on:

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jun 27, 2023
skitt added 2 commits June 28, 2023 17:46
Signed-off-by: Stephen Kitt <skitt@redhat.com>
This avoids an unnecessary allocation.

Also enable the mirror linter which flags such issues.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt enabled auto-merge (rebase) June 28, 2023 16:10
@skitt skitt merged commit 9371f08 into submariner-io:devel Jun 28, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr791/skitt/depguard-v2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants