fix(rbac): sa and rbac definitions #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMattar
requested review from
mangelajo,
Oats87,
skitt and
tpantelis
as code owners
Sync the SA and RBAC definitions with what we have in submariner-operator. Signed-off-by: Steve Mattar <smattar@redhat.com>
SteveMattar
force-pushed
the
submariner-operator-679
branch
from
52366dc to
ce9f395
Compare
mangelajo
approved these changes
Feb 23, 2021
skitt
approved these changes
Feb 23, 2021
| verbs: | ||
| - '*' | ||
| - apiGroups: | ||
| - lighthouse.submariner.io |
There was a problem hiding this comment.
Why does Engine Pod need access to lighthouse.submariner.io?
Comment on lines
+15
to
+23
| - pods | ||
| - services | ||
| - services/finalizers | ||
| - endpoints | ||
| - persistentvolumeclaims | ||
| - events | ||
| - configmaps | ||
| - secrets | ||
| verbs: |
There was a problem hiding this comment.
@SteveMattar Are we giving more permissions than what is really required?
There was a problem hiding this comment.
@sridhargaddam yes, I did not omit any role. The idea was to allow all permission the component used to have so that we don't break anything by mistake and the next step will be to remove uneeded roles.
This is what I have done in the operator as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync the SA and RBAC definitions with what we have in submariner-operator.
Signed-off-by: Steve Mattar smattar@redhat.com