Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OVN db discovery code from submariner-operator #2790

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Remove OVN db discovery code from submariner-operator #2790

merged 1 commit into from
Sep 11, 2023

Conversation

aswinsuryan
Copy link
Contributor

@aswinsuryan aswinsuryan commented Sep 6, 2023 •
edited
Loading

Remove OVN db discovery code from submariner-operator. This code was moved to route-agent submariner-io/submariner#2662

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2790/aswinsuryan/remove-ovn-db-discovery
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@aswinsuryan aswinsuryan force-pushed the remove-ovn-db-discovery branch 6 times, most recently from 6a48c58 to e9ec31a Compare September 6, 2023 21:30
@aswinsuryan aswinsuryan changed the title Remove OVN db covery code from submariner-operator Remove OVN db discovery code from submariner-operator Sep 7, 2023
@aswinsuryan aswinsuryan force-pushed the remove-ovn-db-discovery branch from e9ec31a to 4356e23 Compare September 7, 2023 18:49
@aswinsuryan aswinsuryan mentioned this pull request Sep 7, 2023
Closed
sridhargaddam
sridhargaddam approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this PR, but it would be helpful if you update the commit message saying that this code is now moved to submariner route-agent pods.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Sep 8, 2023
@sridhargaddam
Copy link
Member

There is a typo in the actual commit message. Please fix it and also update it accordingly.

Remove OVN db covery code from submariner-operator

@skitt skitt force-pushed the remove-ovn-db-discovery branch from 4356e23 to 35a7c28 Compare September 8, 2023 15:33
@skitt
Copy link
Member

skitt commented Sep 8, 2023

I’ve fixed the commit message.

@skitt skitt enabled auto-merge (rebase) September 8, 2023 15:33
@aswinsuryan aswinsuryan force-pushed the remove-ovn-db-discovery branch 4 times, most recently from c0393a0 to 783a580 Compare September 9, 2023 14:24
@mkolesnik mkolesnik mentioned this pull request Sep 11, 2023
Merged
@aswinsuryan @skitt
Remove OVN db dicovery code from submariner-operator
564589d 
This was moved to the route agent.

Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
@skitt skitt force-pushed the remove-ovn-db-discovery branch from b62c6e7 to 564589d Compare September 11, 2023 09:01
@skitt skitt merged commit 34b7f72 into submariner-io:devel Sep 11, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2790/aswinsuryan/remove-ovn-db-discovery]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthapar vthapar vthapar approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

Assignees
No one assigned
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aswinsuryan @submariner-bot @sridhargaddam @skitt @vthapar