Handle non-standard coredns ConfigMap name in SD controller #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr3295/tpantelis/coredns_cm |
Fixes submariner-io/lighthouse#1602 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
dfarrell07
approved these changes
Dec 5, 2024
tpantelis
commented
Dec 5, 2024
| cm := &configMaps.Items[i] | ||
|
|
||
| _, hasCorefile := cm.Data[Corefile] | ||
| if strings.HasSuffix(cm.Name, suffix) && hasCorefile { |
There was a problem hiding this comment.
Based on this comment, we could we just check for the existence of the Corefile data entry. @vthapar @aswinsuryan WDYT?
There was a problem hiding this comment.
this looks good , since it is listing all the configmaps in DefaultCoreDNSNamespace , we should be safe as there should be only one coredns corefile normally in this namespace.
aswinsuryan
approved these changes
Dec 6, 2024
|
🤖 Closed branches: [z_pr3295/tpantelis/coredns_cm] |
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Dec 11, 2024
submariner-io/submariner-operator#3295 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Dec 18, 2024
submariner-io/submariner-operator#3295 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a couple preliminary commits to refactor constants and add additional unit test.
Fixes submariner-io/lighthouse#1602