Update Submariner OVN Documentation #699
Conversation
astoycos
requested review from
dfarrell07,
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr699/astoycos/update-ovn-k-resources |
|
/ovn |
|
/hold until OVN related submariner PR's have merged |
✅ Deploy Preview for elated-bell-2913d9 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
astoycos
force-pushed
the
update-ovn-k-resources
branch
from
47bd5cf to
03d57ae
Compare
astoycos
changed the title
|
@astoycos as you probably noticed, we don't use Prow in this org so you have to manually add labels, etc. To mark a PR as draft, we typically use https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request as documented here. |
|
Yep no worries! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
nyechiel
added
confirmed
There was a problem hiding this comment.
This looks outstanding, major fixes/improvements. Thank you @astoycos!
Are we ready to undraft/review/merge?
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Nice diagram with explanation @astoycos, thanks.
There was a problem hiding this comment.
@astoycos In the attached diagram, On OVN Submariner router, it is mentioned that "OVN Nat rules are applied here to ensure traffic is SNAT'ed to the globalnetIP when Globalnet is enabled".
Since this will be done when we support OVN with Globalnet and is not there currently, I'm not sure if we should capture this in the diagram. Basically, it might give an impression that Globalnet is supported even with OVN by looking into the diagram. What you do say?
|
@dfarrell07 This should be pretty much ready to go, I just wonder if we should wait until submariner-io/submariner#1689? Although there isn't any major architectural changes, I may need to edit/augment these docs based on reviews |
|
@vthapar this one should be ready to get merged now, can you please take it? |
vthapar
changed the title
| The following diagram illustrates the OVN Kubernetes handler architecture where the | ||
| blue elements represent the OVN Kubernetes native network elements and the yellow | ||
| elements are introduced by Submariner. | ||
| The following diagram illustrates the required Submariner OVN architecture overlayed |
There was a problem hiding this comment.
Can you please copy the original image to the following PPT [*] and add the following comment which will help us to make further changes in future if required.
<!-- Image Source: https://docs.google.com/presentation/d/180CtHZnr9PP5Rh98VEmkQz3ovc5AGXG9wosoHMLhgaY/edit -->
2271d60 to
f572960
Compare
This commit updates the documents involving the submariner + OVN-K integration, and also re-does the architecture diagram. Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
astoycos
force-pushed
the
update-ovn-k-resources
branch
from
f572960 to
949d8f1
Compare
|
🤖 Closed branches: [z_pr699/astoycos/update-ovn-k-resources] |
|
Thanks @astoycos |
This commit updates the documents involving the
submariner + OVN-K integration, and also re-does
the architecture diagram.
Signed-off-by: Andrew Stoycos astoycos@redhat.com