Merge the api module back into the main module #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr1612/skitt/merge-api |
skitt
force-pushed
the
merge-api
branch
4 times, most recently
from
8e6b36a
to
1ffed1a
Compare
Go dependencies are handled by package, not by module, and per-package splits are handled correctly. Having a separate package makes it easier to track dependencies, but it can cause friction when handling sub-module updates, and it leads to difficulties with go install (see <golang/go#44840>). Signed-off-by: Stephen Kitt <skitt@redhat.com>
dfarrell07
approved these changes
Dec 13, 2021
tpantelis
approved these changes
Dec 15, 2021
|
🤖 Closed branches: [z_pr1612/skitt/merge-api] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go dependencies are handled by package, not by module, and per-package
splits are handled correctly. Having a separate package makes it
easier to track dependencies, but it can cause friction when handling
sub-module updates, and it leads to difficulties with go install (see
golang/go#44840).
Signed-off-by: Stephen Kitt skitt@redhat.com