Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate PublishNotReadyAddresses flag to GN internal service #3219

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

tpantelis
Copy link
Contributor

Fixes #3216

Fixes submariner-io#3216

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3219/tpantelis/publish_not_ready
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@tpantelis tpantelis added ready-to-test When a PR is ready for full E2E testing backport This change requires a backport to eligible release branches release-note-needed Should be mentioned in the release notes labels Nov 18, 2024
@tpantelis tpantelis enabled auto-merge (rebase) November 18, 2024 16:38
@tpantelis tpantelis merged commit 56490aa into submariner-io:devel Nov 18, 2024
73 of 74 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3219/tpantelis/publish_not_ready]

@dfarrell07
Copy link
Member

I see the backports are for 0.18 and 0.19 but the release notes are for 0.18 and 0.20. Should there also be a 0.19 release note?

@dfarrell07
Copy link
Member

I see the backports are for 0.18 and 0.19 but the release notes are for 0.18 and 0.20. Should there also be a 0.19 release note?

Oh there is one it's just not linked here submariner-io/submariner-website#1212

tpantelis added a commit to submariner-io/submariner-website that referenced this pull request Nov 21, 2024
submariner-io/submariner#3219

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis added a commit to submariner-io/submariner-website that referenced this pull request Nov 21, 2024
submariner-io/submariner#3219

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Dec 3, 2024
submariner-io/submariner#3219

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
dfarrell07 pushed a commit to submariner-io/submariner-website that referenced this pull request Dec 4, 2024
submariner-io/submariner#3219

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This change requires a backport to eligible release branches backport-handled ready-to-test When a PR is ready for full E2E testing release-note-handled release-note-needed Should be mentioned in the release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Honor publishNotReadyAddresses flag for non headless services
4 participants