Create await-node-ready binary and add to gateway and route-agent images #3237
Conversation
Related to submariner-io/submariner-operator#3274 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr3237/tpantelis/await_mode_ready |
| @@ -75,6 +75,8 @@ bin/%/submariner-route-agent: $(shell find pkg/routeagent_driver) | |||
| bin/%/submariner-globalnet: $(shell find pkg/globalnet) | |||
| GOARCH=$(call dockertogoarch,$(patsubst bin/linux/%/,%,$(dir $@))) ${SCRIPTS_DIR}/compile.sh $@ ./pkg/globalnet | |||
|
|
|||
| bin/%/await-node-ready: $(shell find pkg/await_node_ready) | |||
There was a problem hiding this comment.
This also uses pkg/node and pkg/versions.
| bin/%/await-node-ready: $(shell find pkg/await_node_ready) | |
| bin/%/await-node-ready: $(shell find pkg/await_node_ready pkg/node pkg/versions) |
There was a problem hiding this comment.
Ok but is that needed? Route agent only specifies $(shell find pkg/routeagent_driver) but it uses other packages as well. Same with globalnet - $(shell find pkg/globalnet). The executable binary runs fine locally.
There was a problem hiding this comment.
It doesn’t affect the binary that gets built, it only determines when it gets rebuilt. But this approach is inherently brittle, I’ve got a better one — let’s merge this and I’ll fix all the binaries properly.
|
🤖 Closed branches: [z_pr3237/tpantelis/await_mode_ready] |
Related to submariner-io/submariner-operator#3274