-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak(subo): Rename scc -> scn in subo everywhere #334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are a lot of linting-related changes that aren't related to the SCC -> SCN swap. Should we land those separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also normalize to controlplane
over control-plane
? This was always intended for the Docker images.
templates/scc-k8s/.suborbital/scc-controlplane-deployment.yaml.tmpl
Outdated
Show resolved
Hide resolved
@ospencer on one hand I understand the need for it, on the other, the linting was broken in the previous version as it used the linting config from a previous version of gci. I figured if I have to change some of the linting anyways, I might as well standardise the lints between subo and scn (gci and revive to unearth the import shadows). To me it's a case of the boyscout rule (leave code looking better than you found it) in this case, and because it's somewhat related, I think it's fine to leave them in for now. Generally I try to separate out things into different PRs. |
b5a02a1
to
ec9a112
Compare
Co-authored-by: Dylan Arbour <arbourd@users.noreply.github.com>
ec9a112
to
bd66780
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires an SCC release
Closing this as it has been done in |
Closes #332
Replaces #333