Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(subo): Rename scc -> scn in subo everywhere #334

Closed
wants to merge 8 commits into from

Conversation

javorszky
Copy link
Contributor

Closes #332

Replaces #333

  • also fixed a variable / package name collision
  • moved some details to consts, and updated usages accordingly

Copy link
Contributor

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a lot of linting-related changes that aren't related to the SCC -> SCN swap. Should we land those separately?

Copy link
Contributor

@arbourd arbourd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also normalize to controlplane over control-plane? This was always intended for the Docker images.

@javorszky
Copy link
Contributor Author

It looks like there are a lot of linting-related changes that aren't related to the SCC -> SCN swap. Should we land those separately?

@ospencer on one hand I understand the need for it, on the other, the linting was broken in the previous version as it used the linting config from a previous version of gci.

I figured if I have to change some of the linting anyways, I might as well standardise the lints between subo and scn (gci and revive to unearth the import shadows).

To me it's a case of the boyscout rule (leave code looking better than you found it) in this case, and because it's somewhat related, I think it's fine to leave them in for now. Generally I try to separate out things into different PRs.

@arbourd arbourd force-pushed the gabor/332-on-main branch from b5a02a1 to ec9a112 Compare August 2, 2022 16:38
@arbourd arbourd force-pushed the gabor/332-on-main branch from ec9a112 to bd66780 Compare August 2, 2022 16:39
Copy link
Contributor

@arbourd arbourd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires an SCC release

@arbourd
Copy link
Contributor

arbourd commented Nov 22, 2022

Closing this as it has been done in suborbital/templates. Thanks @javorszky!

@arbourd arbourd closed this Nov 22, 2022
@arbourd arbourd deleted the gabor/332-on-main branch November 24, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename SCC -> SCN everywhere
3 participants