fix: Remove leading underscore #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbourd
force-pushed
the
remove-leading-underscore
branch
from
91cb8b3 to
6a9b37d
Compare
|
@arbourd in the |
go-envconfig made a change in v0.8.x where any leading underscore is invalid and will break env var parsing. This commit removes the leading prefixed underscore from built-ins. All new prefixes must end with an underscore when this change is released and adopted.
arbourd
force-pushed
the
remove-leading-underscore
branch
from
6a9b37d to
bb50308
Compare
arbourd
commented
Dec 13, 2022
Comment on lines
+79
to
+83
| // Append trailing _ if prefix is missing one | ||
| if !strings.HasSuffix(prefix, "_") { | ||
| prefix = prefix + "_" | ||
| } | ||
|
|
There was a problem hiding this comment.
We could describe this in the docs but I think we'd want people to use the prefix APP_ over APP, where this fallback exists for backwards compatibility reasons.
There was a problem hiding this comment.
Nah we'll be sunsetting vektor eventually so no point in doing anything special. This is good.
cohix
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-envconfigmade a change in v0.8.x where any leading underscore (ex:_APP_NAME) is invalid and will break env var parsing.This commit removes the leading prefixed underscore from built-in options, and sets the default prefix string to
VK_.All new prefixes must end with an underscore when this change is released and adopted. For example, an app that used
_MY_ENVfor an env var andPREFIXfor the prefix, but be changed toPREFIX_for the prefix andMY_ENVfor the env var.