Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing file close #20

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix: add missing file close #20

merged 1 commit into from
Aug 23, 2022

Conversation

luisdavim
Copy link
Collaborator

The Read function opens a file but never closes it...

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #20 (077cbe0) into master (c13b0ab) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   85.79%   85.88%   +0.08%     
==========================================
  Files           1        1              
  Lines         169      170       +1     
==========================================
+ Hits          145      146       +1     
  Misses         19       19              
  Partials        5        5              
Impacted Files Coverage Δ
gotenv.go 85.88% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luisdavim luisdavim requested a review from subosito August 22, 2022 20:21
@subosito subosito merged commit d94fdbe into master Aug 23, 2022
@luisdavim luisdavim deleted the missing_close branch August 23, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants