Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct docs and error message for getProductIDFromJsonLdPageConfig_() #3605

Open
xurizaemon opened this issue Dec 20, 2024 · 0 comments
Open

Correct docs and error message for getProductIDFromJsonLdPageConfig_() #3605

xurizaemon opened this issue Dec 20, 2024 · 0 comments

Comments

@xurizaemon
Copy link

xurizaemon commented Dec 20, 2024 •
edited
Loading

Currently, if a product ID is not obtained from getProductIDFromJsonLdPageConfig_, the returned error is:

Showcase articles must define a publisher ID with either JSON-LD or Microdata.

The current error appears to misdirect integrators.

I believe this (and the function docs) should warn the user about the product ID, not the publisher ID.

#3606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xurizaemon