Explicitly log user-initiated cancellations of the Subscription Linking dialog #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everyplace
requested review from
ChrisAntaki,
jpettitt,
justinchou-google,
oyj9109 and
Wayne-X
as code owners
ChrisAntaki
reviewed
Feb 14, 2024
| @@ -69,6 +69,18 @@ export class SubscriptionLinkingFlow { | |||
| args, | |||
| /* shouldFadeBody= */ false | |||
| ); | |||
|
|
|||
| activityIframeView.onCancel(() => { | |||
| const CompletionStatus = AnalyticsEvent.EVENT_SUBSCRIPTION_LINKING_FAILED; | |||
There was a problem hiding this comment.
Could this variable name be camel cased?
go/tsjs-style#naming-rules-by-identifier-type
|
Could you write a unit test (or tests) to cover this cancellation? |
ChrisAntaki
approved these changes
Feb 14, 2024
ChrisAntaki
reviewed
Feb 15, 2024
| @@ -127,4 +131,15 @@ describes.realWin('SubscriptionLinkingFlow', (env) => { | |||
| ).to.eventually.be.rejectedWith('Dialog error'); | |||
| }); | |||
| }); | |||
|
|
|||
| it.only('resolves promise with success=false when cancelled', async () => { | |||
There was a problem hiding this comment.
Could you remove the .only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
onCancelhandler within the Subscription Linking flow, which now emits the NEWACTION_SUBSCRIPTION_LINKING_CLOSEevent. The second parameter inlogSwgEventspecifies that this was a user-initaited action to disambiguate the two.User-initiated event example, from when a user closes the window:
{ "eventType": 1086, "eventOriginator": 1, "isFromUserAction": true, "additionalParameters": null, "timestamp": 1707883786769 }