Await on getEntitlements in getAvailableIntervention #3526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a race condition between
start
andgetAvailableInterventions
wherestart
will not necessarily callgetEntitlements
before it's needed bygetAvailableInterventions
. This change removes the need to callstart
by havinggetAvailableInterventions
make its own call.This will not duplicate the network call, as the entitlements manager will keep one promise until
reset
has been called. Additionallystart
will not even make agetEntitlements
call on unlocked content, so we need to remove our dependency on it either way.Tested manually on the
enterprise-funnel.html
andenterprise-funnel-manual.html
pages.