Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rewarded ad narrow screen width #3533

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Update rewarded ad narrow screen width #3533

merged 3 commits into from
Jul 17, 2024

Conversation

mhkawano
Copy link
Contributor

@mhkawano mhkawano marked this pull request as ready for review July 16, 2024 17:14
@justinchou-google
Copy link
Contributor

The "after" definitely looks better than the "before" in my opinion, but have we discussed with Clara/Milind what the mobile view should look like?

@mhkawano
Copy link
Contributor Author

I believe that was the intended behavior, but it just doesn't work in this case. Will send them a message confirming.

@mhkawano mhkawano merged commit 8490f74 into subscriptions-project:main Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchou-google justinchou-google justinchou-google approved these changes

@ChrisAntaki ChrisAntaki Awaiting requested review from ChrisAntaki ChrisAntaki is a code owner

@jpettitt jpettitt Awaiting requested review from jpettitt jpettitt is a code owner

@oyj9109 oyj9109 Awaiting requested review from oyj9109 oyj9109 is a code owner

@Wayne-X Wayne-X Awaiting requested review from Wayne-X Wayne-X is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhkawano @justinchou-google