FPA M0.5 #3543
FPA M0.5 #3543
Conversation
| @@ -243,6 +244,7 @@ export class BasicRuntime implements BasicSubscriptions { | |||
| autoPromptType, | |||
| alwaysShow, | |||
| isClosable, | |||
There was a problem hiding this comment.
@kristenwang Are we ok updating this value for OnsitePreview to also use contentType? I believe in today's flow we use isClosable, but this will be deprecated.
There was a problem hiding this comment.
Note: we can no longer assume the contribution prompt will be present in the audience actions for all contribution revenue models.
|
Thanks for thoroughly documented description. The overall logic looks good and I left some minor comments. Regarding some questions in the description
I feel like having a fallback value based on content type would generally make sense in case prompt level dimissibility is absent (e.g., no action orchestration available for onsite preview). |
| (action) => action.configurationId === nextIntervention.configId | ||
| ); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Just to clarify, are there cases where flag is enabled but article.actionOrchestration is absent?
There was a problem hiding this comment.
When all experiment flags are on, we always expect actionOrchestration to be present. Even in the case when interventionFunnel is absent (where no funnel is matched).
This is to put prevent errors when the server side experiment is not on.
justinchou-google
requested review from
ChrisAntaki,
jpettitt and
Wayne-X
as code owners
justinchou-google
merged commit f0deefb
into
subscriptions-project:main
This reverts commit f0deefb.
Adds a sequence flow to AutoPromptManager to process actionOrchestration from the article endpoint.
contentType(to determine which funnel to fetch) equivalent to what is written to thepageConfig. NOTE: this differs slightly from the current prod version's computation ofisClosable, which also falls back to revenue model.isClosable.CLOSEDcontentType explicitly skips over FrequencyCapping logic, even if FrequencyCapping values are provided. I believe this is the only contentType specific logic in the flow.secondsDurationproto on thefrequencyCapDuration: this will be validated and converted as part ofgetTargetedInterventionFunnelAction (TODO b/362344744).nanoimplementation from Duration.