Sync proto with g3 to include url_from_markup AnalyticsContext field #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnalyticsContext field
caroljli
requested review from
ChrisAntaki,
jpettitt,
mhkawano,
oyj9109 and
Wayne-X
as code owners
mhkawano
approved these changes
Sep 19, 2024
mhkawano
requested changes
Sep 20, 2024
test/e2e/vrt/baseline/chrome_mac/extendedAccess/regwall_all_experiments_on.png
Outdated
Show resolved
Hide resolved
in tests to fix e2e testing error.
mhkawano
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to log the
canonicalReftag from markup to investigate why we have mismatching impressions logged for domains that don't belong to the publication.