Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sophora-webclient] make service configurable in webclient chart #103

Merged
merged 2 commits into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/sophora-webclient/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.2.0
version: 1.2.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
14 changes: 9 additions & 5 deletions charts/sophora-webclient/templates/service.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
kind: Service
apiVersion: v1
kind: Service
metadata:
name: {{ include "webclient.fullname" . }}
labels:
{{- include "webclient.labels" . | nindent 4 }}
spec:
selector: {{- include "webclient.selectorLabels" . | nindent 4 }}
type: {{ .Values.service.type }}
ports:
- protocol: TCP
port: 8080
targetPort: 8080
- port: {{ .Values.service.port }}
targetPort: http
protocol: TCP
name: http
selector:
{{- include "webclient.selectorLabels" . | nindent 4 }}
4 changes: 4 additions & 0 deletions charts/sophora-webclient/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ ingress:
hosts:
annotations: {}

service:
type: ClusterIP
port: 8080

extraDeploy: []

serviceMonitor:
Expand Down
Loading