Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal users get error on successful device profile deletion #134

Closed
jpbostic opened this issue Sep 2, 2020 · 0 comments · Fixed by #135
Closed

Normal users get error on successful device profile deletion #134

jpbostic opened this issue Sep 2, 2020 · 0 comments · Fixed by #135
Labels
bug Something isn't working

Comments

@jpbostic
Copy link

jpbostic commented Sep 2, 2020

Describe the bug

When a normal user (logged in via SAML) deletes a device profile, they get an error page, even though the deletion is successful.

To Reproduce

Steps to reproduce the behavior:

  1. Run docker image 1.3.2 (subspacecommunity/subspace:1.3.2 which is from commit a996119) and configure for SAML
  2. Login via SAML as normal user and add device profiles
  3. Attempt to delete one of the device profiles (works but an error page is shown)
  4. Logout and then login as admin user
  5. Attempt to delete one of the device profiles for the normal user above (works with no errors)

Note

Expected behavior

Profile deletion should work with no errors for both a normal user and an admin editing that user's account or device profiles.

Screenshots

Screenshot_from_2020-09-02_17-27-57 01
Screenshot_from_2020-09-02_17-28-12 01

Desktop (please complete the following information):

NA - error is not client platform specific.

Smartphone (please complete the following information):

NA - error is not client platform specific.

Additional context

To diagnose this issue, I ran subspace in debug mode inside the docker container, which helped locate the issue, which is in the "profileDeleteHandler" method in cmd/subspace/handlers.go . Will submit pull request with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants