Redirect to /user/edit path only needed if we are admin. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
gavinelder
approved these changes
Sep 20, 2020
jack1902
reviewed
Oct 27, 2020
|
@jpbostic just deployed in production with my fork at https://github.com/waycarbon/subspace with no issues. Thanks! |
gchamon
approved these changes
May 17, 2021
|
@subspacecommunity/subspace-maintainers I believe this is ok to merge. Need a couple more eyes on it though. |
agonbar
approved these changes
Jun 3, 2021
|
@all-contributors please add @jpbostic for code |
|
I've put up a pull request to add @jpbostic! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves: #134
Background
While evaluating an instance of Subspace running in its docker container (subspacecommunity/subspace:latest), I noticed that when I login as a normal user (via SAML), deletion of device profiles works but I get an error page after I click the "Delete device?" popup.
Running in debug mode showed a "permission denied" on the /user/edit path. When looking at a clone of the repo, I realized that the profileDeleteHandler is trying to redirect back to the /user/edit path even when I'm not logged in as an admin. Normal behavior should be to only redirect to /user/edit if I'm admin and otherwise move on (the redirect to the normal "success" path is immediately below this and it was obviously never being reached).
Changes
Testing
This was tested on a VM running a docker image built from these changes. Profiles were added to a normal account and then deleted using both an admin account and that regular account. Both ways now work without error.