-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/totp default admin #111
Conversation
db142cd
to
8586b81
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
That force-push was to cause SonarCloud to re-trigger. i have disabled the warning about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I wanted to give a test in a local setup to be sure everything was fine, for the next iteration of the CI I think I need to focus on unit testing or something on the likes to save time.
The change is awseome @jack1902, thanks for all the work done ˆˆ.
key, err := totp.Generate( | ||
totp.GenerateOpts{ | ||
Issuer: httpHost, | ||
AccountName: config.Info.Email, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the problem, it should be c.Info.Email not config
I don't see this option when I go to settings, is there a flag or some way to enable this? I'd love to use it on my admin account. |
to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves: #104
Background
Wanted to secure the default user of subspace with TOTP. Now it is possible to turn on TOTP for the default user by visiting
/settings
and scanning the QR code with your phone (or putting the secret key into something else)Changes
/settings
/settings
(only visible if TOTP is already configured)Admin
(This means both SAML Signed in Admin and the default Admin)Pics
Initial Setup of MFA
Reset MFA (will then result in the above page)
Sign in page for default admin account if TOTP has been saved
Testing
Ran this locally multiple times on my Droplet in Digital Ocean (i'm using rsync to sync changes to my box and then running
docker-compose up --build -d
whenever changes are made togo
files. For changes related static files i simply specify--debug
in the build step forgo-bindata
and mountweb/
into the running container.go-bindata
then reads these files live on each request :D)