Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for providing multiple dns servers #140

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

syphernl
Copy link

@syphernl syphernl commented Oct 13, 2020

to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves:

Background

Out of the box Subspace only accepts a single nameserver. In order to prevent issues when it's unavailable, it would be nice to configure more than one.

Changes

  • Renamed SUBSPACE_NAMESERVER to SUBSPACE_NAMESERVERS
  • Added support for providing a comma-separated list of nameservers (e.g. SUBSPACE_NAMESERVERS=1.1.1.1,8.8.8.8,9.9.9.9)
  • Changed the default value of SUBSPACE_NAMESERVERS to 1.1.1.1,1.0.0.1

Testing

Local container was built and spun-up.

Config

SUBSPACE_NAMESERVER=1.1.1.1,8.8.8.8,9.9.9.9

Results in:

subspace    | dnsmasq: using nameserver 1.1.1.1#53
subspace    | dnsmasq: using nameserver 8.8.8.8#53
subspace    | dnsmasq: using nameserver 9.9.9.9#53

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@agonbar agonbar merged commit bb0375a into subspacecommunity:master Jan 18, 2021
@syphernl syphernl deleted the feat/multi_dns branch January 18, 2021 09:04
@agonbar
Copy link
Collaborator

agonbar commented Jan 23, 2021

@all-contributors please add @syphernl for code

@allcontributors
Copy link

@agonbar

I've put up a pull request to add @syphernl! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants