Add support for Bitfinity Mainnet #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octo-gone
force-pushed
the
octo-gone/feat/bitfinity-mainnet-support
branch
from
d356049
to
75a9692
Compare
tmcgroul
requested changes
Sep 13, 2024
tmcgroul
reviewed
Oct 5, 2024
| for tx in block['transactions']: | ||
| if tx.get('type') is None: | ||
| if 'maxPriorityFeePerGas' in tx: | ||
| tx['type'] = '0x2' |
There was a problem hiding this comment.
i have an idea that this assuption about tx type shoul be a part of validation logic and not ingestion
There was a problem hiding this comment.
as i noticed many libraries that provide validation they just try to substitute missing values
There was a problem hiding this comment.
I don't think in this exact case it would be good to move to validation logic. But in general yes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.