fix validation logic for date datatype in duckdb and postgres #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is pre-requisite to using test cases from substrait directly. substrait testcases have examples which can only contain the date part but the python client returns a datetime object. Converting these to strings and comparing is not quite right. e.g., '2024-03-01' == '2024-03-01:00:00:00' will fail if we do string compare. The fix is to not compare the empty fields hrs, mins, secs, etc if we only contain the date part
EpsilonPrime
approved these changes
Dec 10, 2024
| if ( | ||
| isinstance(result, datetime.datetime) | ||
| and has_only_date(result) | ||
| and str(result.date()) == case_result |
There was a problem hiding this comment.
In the long run we need to make sure that we're testing types as well as values. This is fine for now as a workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is pre-requisite to using test cases from substrait directly.
substrait testcases have examples which can only contain the date part but the python client returns a datetime object.
Converting these to strings and comparing is not quite right. e.g., '2024-03-01' == '2024-03-01:00:00:00' will fail if we do string compare.
The fix is to not compare the empty fields hrs, mins, secs, etc if we only contain the date part