Add optional test executable and enable Substrait C API tests #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are some of the checks failing? |
It is failing in unchanged file and this PR doesn't change workflow. So don't have a clue based on failure. I will debug it. |
Issue was workflow refers to latest main instead of a specific commit. Duckdb moved ahead with breaking change. I will raise another PR to fix it |
anshuldata
force-pushed
the
anshul/EnableCTest
branch
from
0ef983b
to
e2a3fc0
Compare
anshuldata
changed the title
anshuldata
changed the title
|
Raised #122 to fix Workflow to run with a particular commit of duckdb. Once it is merged, I will rebase this one |
- Added an option `ENABLE_TEST_EXE` to build an optional test executable in `test/c/CMakeLists.txt` - Created a new `main.cpp` file to run C tests. - Updated `test_substrait_c_api.cpp` to fix build errors and remove unused includes. - Included the new test directory in the main `CMakeLists.txt`.
jacques-n
force-pushed
the
anshul/EnableCTest
branch
from
e2a3fc0
to
56ebc35
Compare
EpsilonPrime
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENABLE_TEST_EXEto build an optional test executable intest/c/CMakeLists.txtmain.cppfile to run C tests.test_substrait_c_api.cppto fix build errors and remove unused includes.CMakeLists.txt.