feat: implement cast op for Cast expression
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
cast-expr
branch
from
9755fef to
a9816c5
Compare
|
For lack of other place to keep track of this, the following message types/fields are still missing for the plan of TPC-H Q6 of Isthmus:
@dshaaban01: you may also find that interesting. |
ingomueller-net
force-pushed
the
cast-expr
branch
from
a9816c5 to
5376c9b
Compare
jpienaar
approved these changes
Feb 6, 2025
ingomueller-net
force-pushed
the
cast-expr
branch
from
5376c9b to
66eeaaf
Compare
This PR implements the `cast` op, which corresponds to the `Cast` expression in Substrait. This is one of the few remaining message types we need to support to get a first TPC-H query round-tripped.
ingomueller-net
force-pushed
the
cast-expr
branch
from
66eeaaf to
c6b0ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on and, therefor, includes #75.
This PR implements the
castop, which corresponds to theCastexpression in Substrait. This is one of the few remaining message types we need to support to get a first TPC-H query round-tripped.