-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce varchar<L> type #82
base: main
Are you sure you want to change the base?
feat: introduce varchar<L> type #82
Conversation
lib/Target/SubstraitPB/Export.cpp
Outdated
} else if (auto varCharType = dyn_cast<VarCharType>(literalType)) { | ||
auto varChar = | ||
std::make_unique<::substrait::proto::Expression_Literal_VarChar>(); | ||
varChar->set_length(mlir::cast<StringAttr>(value).size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take the length from the type, not from the value.
10fc673
to
b225641
Compare
@ingomueller-net I made some thoughts about the creation of a This is what I came up with:
Let me know if this is overkill or if I should add this (or elements of it).
|
This PR introduces the varchar compound type, which represents a variable-length Unicode string of up to L characters.