Add invocation property to AggregateFunction message for specifying distinct vs all #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesRTaylor
force-pushed
the
aggregate_func_invocation
branch
2 times, most recently
from
8586aed to
b65deab
Compare
jacques-n
reviewed
May 11, 2022
JamesRTaylor
force-pushed
the
aggregate_func_invocation
branch
from
b65deab to
4b0879f
Compare
…ying distinct vs all * feat: add new invocation property to AggregateFunction message * docs: add AggregateFunction invocation docs
JamesRTaylor
force-pushed
the
aggregate_func_invocation
branch
from
bfdf260 to
f27e8c0
Compare
JamesRTaylor
changed the title
|
I've updated the comment, @jacques-n. I also moved the new invocation property to the right proto message. |
|
@cpcloud and @jvanstraten , you good with this change? It's not breaking but it is an introduction of a new feature in the spec. |
cpcloud
approved these changes
May 12, 2022
|
Thanks @JamesRTaylor ! |
|
Looks like I'm too late, but looks good to me for what it's worth :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.