Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding SUM0 definition for aggregate functions #465

Merged
merged 3 commits into from
Mar 27, 2023
Merged

feat: adding SUM0 definition for aggregate functions #465

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e72900e
feat(sum0): adding SUM0 definition for aggregate functions
vibhatha Mar 7, 2023
ccba491
fix: update description
vibhatha Mar 24, 2023
cce01b1
fix: address reviews
vibhatha Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions extensions/functions_arithmetic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,6 +922,72 @@ aggregate_functions:
decomposable: MANY
intermediate: fp64?
return: fp64?
- name: "sum0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An analog could be the multiply function returning one for a set of zero elements. Do we want to make a similar change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you’re correct. We should probably add that in another PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, no need to make this PR do too much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

description: >
Sum a set of values. The sum of zero elements yields zero.

Null values are ignored.
impls:
- args:
- name: x
value: i8
options:
overflow:
values: [ SILENT, SATURATE, ERROR ]
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: i64
return: i64
- args:
- name: x
value: i16
options:
overflow:
values: [ SILENT, SATURATE, ERROR ]
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: i64
return: i64
- args:
- name: x
value: i32
options:
overflow:
values: [ SILENT, SATURATE, ERROR ]
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: i64
return: i64
- args:
- name: x
value: i64
options:
overflow:
values: [ SILENT, SATURATE, ERROR ]
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: i64
return: i64
- args:
- name: x
value: fp32
options:
overflow:
values: [ SILENT, SATURATE, ERROR ]
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: fp64
return: fp64
- args:
- name: x
value: fp64
options:
overflow:
values: [ SILENT, SATURATE, ERROR ]
nullability: DECLARED_OUTPUT
decomposable: MANY
intermediate: fp64
return: fp64
vibhatha marked this conversation as resolved.
Show resolved Hide resolved
- name: "avg"
description: Average a set of values. For integral types, this truncates partial values.
impls:
Expand Down