ADD: Faktory::createMany for bulk-creating factories #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwhitworth
force-pushed
the
add-createMany-method
branch
from
58fcc6f to
df4a420
Compare
UPDATE: Added a newMany counterpart to the createMany method UPDATE: Return of array_map instead of assigning to value UPDATE: Refactor createMany
jmwhitworth
force-pushed
the
add-createMany-method
branch
from
df4a420 to
0a6e794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new static method
Faktory::createMany. This allows for multiple factories to be created at once without the need for writing loops within the tests.I've added basic tests and have updated the readme to include examples. I also made some small changes to the readme for consistency in the use of
Faktoryvsfactory.Due to the test suite not having a database to write to, I added an argument to determine if the records are saved to the database.
As
Faktory::createandFaktory::neware identical with the exception being whether they save to the database, it might be better to implement aFaktory::newManyas a non-saving counterpart. For now, this allowed unit tests to be written despite not being able to mock the required static functions.