Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Remove versioning requirement for Models and Datasets #254

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Remove versioning requirement for Models and Datasets #254

merged 2 commits into from
Oct 13, 2023

Conversation

nstogner
Copy link
Contributor

@nstogner nstogner commented Oct 12, 2023 •
edited
Loading

Fixes #250

samos123
samos123 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@samos123 samos123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the expected behavior when you use increment and a model named my-model already exists? Would it automatically create my-model.v1 next? or does increment only work for models that already have a v[0-9] in their name?

@samos123 samos123 merged commit 9958742 into main Oct 13, 2023
6 checks passed
@samos123 samos123 deleted the remove-versioning-requirement branch October 13, 2023 04:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samos123 samos123 samos123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sub get crashes when 0 resources?
2 participants
@nstogner @samos123