WIP: Optimistic ZK Game Contract #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puma314
reviewed
Jun 4, 2024
puma314
reviewed
Jun 4, 2024
…optimism into zach/optimistic-zk-tests
zobront
commented
Jun 6, 2024
Comment on lines
279
to
283
| // Validate public values passed to the verifier: The real L1 block root matches the passed l1Root. | ||
| // @todo verify relevant L1 block root matches _publicValues.l1Root | ||
|
|
||
| // Validate public values passed to the verifier: The real commitment to the blob matches the passed blobKzgCommitment. | ||
| // @todo access correct kzg commitment to verify against _publicValues.blobKzgCommitment? |
There was a problem hiding this comment.
After building the STF, come back to finalize these commitments to ensure data is accurate.
zobront
commented
Jun 6, 2024
Comment on lines
+136
to
+138
| // Require that the gap between the reference block and the block being proven is less than MAX_BLOCK_GAP. | ||
| // This is used to avoid attacks where such a large gap is used that the game cannot be completed. | ||
| if (anchorStateRoot.l2BlockNumber + MAX_BLOCK_GAP < l2BlockNumber()) revert InvalidBlockNumber(); |
There was a problem hiding this comment.
I need to think more about these limits to ensure that up to 7 days later, the necessary data will be available via the EVM to prove against.
zobront
pushed a commit
that referenced
this pull request
Aug 14, 2024
* feat: introduce OptimismSuperchainERC20 * fix: contract fixes * feat: add snapshots and semver * test: add supports interface tests * test: add invariant test * feat: add parameters to the RelayERC20 event * fix: typo * fix: from param description * fix: event signature and interface pragma * feat: add initializer * feat: use unstructured storage and OZ v5 * feat: update superchain erc20 interfaces * fix: adapt storage to ERC7201 * test: add initializable OZ v5 test * fix: invariant docs * fix: ERC165 implementation * test: improve superc20 invariant (#11) * fix: gas snapshot --------- Co-authored-by: 0xng <ng@defi.sucks> Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of an Optimistic ZK Contract for the bridge:
MAX_GAME_DURATIONto complete a challenge (expect 7 days)MAX_PROPOSER_DURATION(expect 3.5 days)This contract attempts to model a lot of the patterns, types and interfaces of the existing game contracts, which can feel a little clunky in some areas, but works.
This is still a WIP. Sharing here for early feedback.
Note: Pausing work on this contract to focus on implementing the state transition function in the zkVM. After that's done, will come back to it to tackle: