Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): lock axum to 0.7.4 #1029

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix(sdk): lock axum to 0.7.4 #1029

merged 1 commit into from
Jul 5, 2024

Conversation

mattstam
Copy link
Contributor

@mattstam mattstam commented Jul 3, 2024

Twirp requires axum 0.7.4

error: failed to select a version for `axum`.
    ... required by package `twirp v0.3.0 (https://github.com/github/twirp-rs.git?rev=c85f31f9c54957374e7dcb3534fc52cff0aa2dc5#c85f31f9)`
    ... which satisfies git dependency `twirp` of package `sp1-sdk v0.1.0 (https://github.com/succinctlabs/sp1.git?tag=v1.0.4-testnet#2ce75c6e)`
    ... which satisfies git dependency `sp1-sdk` of package `zkdna-script v0.1.0 (/Users/zachobront/code/zkdna/script)`
versions that meet the requirements `^0.7` (locked to 0.7.4) are: 0.7.4

all possible versions conflict with previously selected packages.

  previously selected package `axum v0.7.5`
    ... which satisfies dependency `axum = "=0.7.5"` of package `sp1-sdk v0.1.0 (https://github.com/succinctlabs/sp1.git?tag=v1.0.4-testnet#2ce75c6e)`
    ... which satisfies git dependency `sp1-sdk` of package `zkdna-script v0.1.0 (/Users/zachobront/code/zkdna/script)`

@puma314
Copy link
Contributor

puma314 commented Jul 5, 2024

Btw, should we make sure this type of stuff gets caught in CI?

@mattstam
Copy link
Contributor Author

mattstam commented Jul 5, 2024

At least with the .github/dependabot.yml for now it won't try to update

@mattstam mattstam merged commit b00b139 into dev Jul 5, 2024
6 checks passed
@mattstam mattstam deleted the mattstam/axum-fix branch July 5, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants