-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exp reverse bits in ir #1093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqn
requested review from
jtguibas and
erabinov
and removed request for
erabinov
July 12, 2024 19:00
jtguibas
reviewed
Jul 12, 2024
jtguibas
reviewed
Jul 12, 2024
jtguibas
approved these changes
Jul 12, 2024
jtguibas
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds IR and circuit instructions for
ExpReverseBits
andHintBits
(bit decomposition of a base field element).Note:
HintBits
does not invoke areceive
interaction on its inputs, but it invokes asend
interaction on its output bits. One may believe that this means that values that are still used in the final computation may be written with zero multiplicity, but since every invocation ofHintBits
comes with assertions (see below), this is not true.An alternative would be to
receive
all the inputs, but since the values are not being constrained for theHintBits
operation itself, this seems kind of useless.When an IR
HintBits
instruction is compiled, it yields many assert statements that constrain the result to be the bit decomposition. These constraints are untested, but I checked that they do in fact yield instructions. Additionally, I essentially just copy-pasted them, so they should work.