feat: autoscale shard / batch size #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: yuwen/ci-lowmem
|
jtguibas
reviewed
Aug 29, 2024
.github/workflows/pr.yml
Outdated
| @@ -262,3 +262,38 @@ jobs: | |||
| --branch-name "${{ github.head_ref || github.ref_name }}" \ | |||
| --commit-hash "${{ github.sha }}" \ | |||
| --author "${{ github.event.pull_request.user.login || github.actor }}" | |||
|
|
|||
| # Runs on a c7a.2xlarge machine, which only has 16GiB memory. | |||
| memory: | |||
There was a problem hiding this comment.
let's call this low-memory
jtguibas
reviewed
Aug 29, 2024
.github/workflows/pr.yml
Outdated
|
|
||
| # Runs on a c7a.2xlarge machine, which only has 16GiB memory. | ||
| memory: | ||
| name: Memory |
jtguibas
reviewed
Aug 29, 2024
.github/workflows/pr.yml
Outdated
| @@ -262,3 +262,38 @@ jobs: | |||
| --branch-name "${{ github.head_ref || github.ref_name }}" \ | |||
| --commit-hash "${{ github.sha }}" \ | |||
| --author "${{ github.event.pull_request.user.login || github.actor }}" | |||
|
|
|||
| # Runs on a c7a.2xlarge machine, which only has 16GiB memory. | |||
yuwen01
changed the title
jtguibas
reviewed
Sep 3, 2024
jtguibas
reviewed
Sep 3, 2024
jtguibas
reviewed
Sep 3, 2024
crates/stark/src/opts.rs
Outdated
| @@ -42,19 +45,47 @@ pub struct SP1CoreOpts { | |||
| pub records_and_traces_channel_capacity: usize, | |||
| } | |||
|
|
|||
| // Calculate the default shard size using an empirically determined formula. | |||
There was a problem hiding this comment.
can u also explain this formula lol
jtguibas
reviewed
Sep 4, 2024
crates/stark/src/opts.rs
Outdated
| let default_shard_size = shard_size(total_available_mem); | ||
| let default_shard_batch_size = shard_batch_size(total_available_mem); | ||
|
|
||
| println!("total memory: {total_available_mem} GB"); |
There was a problem hiding this comment.
don't add random prints to code, use tracing::debug or something
jtguibas
reviewed
Sep 4, 2024
| @@ -57,7 +57,7 @@ fn main() { | |||
| // It is strongly recommended you use the network prover given the size of these programs. | |||
| if args.prove { | |||
| println!("Starting proof generation."); | |||
| let proof = client.prove(&pk, stdin).compressed().run().expect("Proving should work."); | |||
| let proof = client.prove(&pk, stdin).core().run().expect("Proving should work."); | |||
jtguibas
reviewed
Sep 4, 2024
| @@ -46,7 +46,7 @@ fn main() { | |||
|
|
|||
| let execute = client.execute(TENDERMINT_ELF, stdin.clone()).run().expect("proving failed"); | |||
|
|
|||
| let proof = client.prove(&pk, stdin).compressed().run().expect("proving failed"); | |||
jtguibas
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.