chore: allow optional proof shape in core record and program #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: erabinov/proof_shapes
|
erabinov
changed the title
erabinov
changed the title
tamirhemo
reviewed
Aug 30, 2024
crates/core/executor/src/program.rs
Outdated
| @@ -25,13 +26,15 @@ pub struct Program { | |||
| pub pc_base: u32, | |||
| /// The initial memory image, useful for global constants. | |||
| pub memory_image: BTreeMap<u32, u32>, | |||
| /// The shape for the preprocessed tables. | |||
| pub shape: Option<CoreShape>, | |||
There was a problem hiding this comment.
rename to preprocessed_shape?
tamirhemo
reviewed
Aug 30, 2024
| pad_rows_fixed( | ||
| &mut rows, | ||
| || [F::zero(); NUM_ADD_SUB_COLS], | ||
| input.shape.as_ref().map(|s: &CoreShape| s.shape[&MachineAir::<F>::name(self)]), |
There was a problem hiding this comment.
refactor to a method on program and a method on record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.