-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: use vec_map
paging mmu for executor memory
#1461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SP1 Performance Test Results Branch: tqn/perf-executor-slowdown
|
ctian1
reviewed
Sep 4, 2024
ctian1
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some areas to potentially improve:
memory_checkpoint
always allocates as much space (for page pointers) as the largest key (page address). This is not necessary. Perhaps it should be aVecDeque
ofPage
s along with its least address, or perhaps aHashMap
orBTreeMap
would do better. This choice probably depends on the shard size and memory access patterns.memory_checkpoint
isPagedMemory<Option<MemoryRecord>>
which is internally stored asVec<Option<Option<MemoryRecord>>>
. This is not the best for space.memory.rs
. Could be made intoconst
functions taking (the size of) the generic valueV
.