feat: better reduce api #1486
Merged
feat: better reduce api #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratankaliani
reviewed
Sep 6, 2024
crates/core/executor/src/reduce.rs
Outdated
| @@ -0,0 +1,23 @@ | |||
| use serde::{de::DeserializeOwned, Deserialize, Serialize}; | |||
|
|
|||
ratankaliani
reviewed
Sep 6, 2024
crates/core/executor/src/io.rs
Outdated
| use sp1_stark::{baby_bear_poseidon2::BabyBearPoseidon2, ShardProof, StarkVerifyingKey}; | ||
| use sp1_stark::{baby_bear_poseidon2::BabyBearPoseidon2, StarkVerifyingKey}; | ||
|
|
||
| use crate::SP1ReduceProof; | ||
|
|
ratankaliani
reviewed
Sep 6, 2024
crates/core/executor/src/subproof.rs
Outdated
| @@ -3,9 +3,11 @@ | |||
| use std::sync::atomic::AtomicBool; | |||
|
|
|||
ratankaliani
reviewed
Sep 6, 2024
crates/prover/src/utils.rs
Outdated
Comment on lines
17
to
34
| pub fn sp1_vkey_digest_babybear(proof: &SP1ReduceProof<BabyBearPoseidon2Outer>) -> [BabyBear; 8] { | ||
| let proof = &proof.proof; | ||
| let pv: &RecursionPublicValues<BabyBear> = proof.public_values.as_slice().borrow(); | ||
| pv.sp1_vk_digest | ||
| } | ||
|
|
||
| pub fn sp1_vkey_digest_bn254(proof: &SP1ReduceProof<BabyBearPoseidon2Outer>) -> Bn254Fr { | ||
| babybears_to_bn254(&sp1_vkey_digest_babybear(proof)) | ||
| } | ||
|
|
||
| pub fn sp1_commited_values_digest_bn254(proof: &SP1ReduceProof<BabyBearPoseidon2Outer>) -> Bn254Fr { | ||
| let proof = &proof.proof; | ||
| let pv: &RecursionPublicValues<BabyBear> = proof.public_values.as_slice().borrow(); | ||
| let committed_values_digest_bytes: [BabyBear; 32] = | ||
| words_to_bytes(&pv.committed_value_digest).try_into().unwrap(); | ||
| babybear_bytes_to_bn254(&committed_values_digest_bytes) | ||
| } | ||
|
|
There was a problem hiding this comment.
Add doc comments for these functions.
ratankaliani
approved these changes
Sep 6, 2024
|
SP1 Performance Test Results Branch: tamir/better-reduce-api
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.